Skip to content

fix(make-pdf): run setup before preamble footers#1393

Closed
jbetala7 wants to merge 1 commit into
garrytan:mainfrom
jbetala7:oss/fix-1389-make-pdf-setup-order
Closed

fix(make-pdf): run setup before preamble footers#1393
jbetala7 wants to merge 1 commit into
garrytan:mainfrom
jbetala7:oss/fix-1389-make-pdf-setup-order

Conversation

@jbetala7
Copy link
Copy Markdown
Contributor

@jbetala7 jbetala7 commented May 9, 2026

Fixes #1389.

Summary

  • Move the generated MAKE-PDF SETUP block into the make-pdf preamble path so it appears immediately after the runnable preamble.
  • Remove the now-redundant template placeholder and regenerate make-pdf/SKILL.md.
  • Add a regression test for setup ordering and uniqueness.

Testing

  • git diff --check
  • bun run gen:skill-docs --dry-run
  • bun test test/gen-skill-docs.test.ts --test-name-pattern "make-pdf setup ordering"

Note

  • Full test/gen-skill-docs.test.ts still has local external-host freshness failures in this checkout; the tracked Claude-host docs are fresh.

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

@garrytan
Copy link
Copy Markdown
Owner

Absorbed into v1.31.1.0 fix wave (#1413, commit 49cc4ff). Thanks for the make-pdf setup ordering fix @jbetala7 — your patch ships unchanged. Closing this PR with credit.

@garrytan garrytan closed this May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make-pdf: "MAKE-PDF SETUP (run BEFORE any make-pdf command)" is buried 13 sections deep

2 participants